Pause spotify playback when Mopidy paused #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I said in #146, I'm unsure what effect (if any) this will have on ensuring we have continued to buffer sufficient data to allow us to instantly resume playback. libspotify stops sending us any more audio data as soon as we pause which is in contrast to the old behaviour which kept consuming the data until the buffer was full. I have not noticed any issues like this but maybe it'd be an issue on a slow internet connection? But I have noticed the cpu usage is now slightly less when paused (max ~2.4% vs max ~0.7%). So that's a nice bonus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when paused, we stopped consuming audio buffers rather than telling libspotify to pause playback. This lead to undesirable behaviour on other clients if the "paused" mopidy-spotify instance was offline at the time playback was started on another Spotify client, causing it to miss the playback token lost signal from the other client (see #146).