Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DISTINCT_FIELDS are limited to a subset of tags #1899

Closed
kingosticks opened this issue Apr 17, 2020 · 0 comments
Closed

DISTINCT_FIELDS are limited to a subset of tags #1899

kingosticks opened this issue Apr 17, 2020 · 0 comments
Assignees
@kingosticks
Labels
A-core Area: Core layer C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Milestone
v3.3.0

Comments

@kingosticks
Copy link
Member

kingosticks commented Apr 17, 2020 •
edited
Loading

Mopidy's allowed DISTINCT_FIELDS are limited to:

  • track
  • artist
  • albumartist
  • album
  • composer
  • performer
  • date
  • genre

Which is only a subset of the available tags. This limits what Mopidy-MPD can support in it's list command (related to mopidy/mopidy-mpd#29).

Furthermore, 'track' is ambiguous here (#535). It should be either 'track_name' or 'track_no' to match up with SEARCH_FIELDS and with what Mopidy-Local is expecting.
@kingosticks kingosticks self-assigned this Apr 17, 2020
@kingosticks kingosticks added A-core Area: Core layer C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal labels Apr 17, 2020
kingosticks added a commit to kingosticks/mopidy that referenced this issue Apr 18, 2020
@kingosticks
core: distinct supports same fields as search. (Fixes mopidy#1899)
35fbead 
With the exception of 'any' as it doesn't make sense here.

Also added some basic get_distinct tests.
kingosticks added a commit to kingosticks/mopidy that referenced this issue Apr 18, 2020
@kingosticks
core: distinct supports same fields as search. (Fixes mopidy#1899)
1d9fc3e 
With the exception of 'any' as it doesn't make sense here.

Also added some basic get_distinct tests.
@kingosticks kingosticks mentioned this issue Apr 20, 2020
Closed
@jodal jodal added this to the v3.1.0 milestone Apr 21, 2020
@jodal jodal modified the milestones: v3.1.0, Next feature release Dec 15, 2020
kingosticks added a commit to kingosticks/mopidy that referenced this issue Jan 21, 2022
@kingosticks
core: distinct supports same fields as search. (Fixes mopidy#1899)
c06dd22 
With the exception of 'any' as it doesn't make sense here.

Also added some basic get_distinct tests.
2e0byo added a commit to 2e0byo/mopidy-tidal that referenced this issue May 7, 2023
@2e0byo
fix: handle track_name in get_distinct.
6a1eb49 
See mopidy/mopidy#1899.
@jodal jodal modified the milestones: v3.4.0, v3.3.0 Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kingosticks kingosticks

Labels
A-core Area: Core layer C-enhancement Category: A PR with an enhancement or an issue with an enhancement proposal
Projects
None yet
Milestone
v3.3.0
Development

No branches or pull requests
2 participants
@jodal @kingosticks