Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes commonTrackProperties and SelectionParameters #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removes commonTrackProperties and SelectionParameters #65

wants to merge 1 commit into from

Conversation

wilaw
Copy link
Collaborator

@wilaw wilaw commented Jul 25, 2024

This PR simplifies the structure of the catalog by:

  1. Removing the commonTrackProperties object. All properties are now repeated for each track.
  2. Removing selectionParameters object. Conceivable , any track property can be used for selection, therefore it is arbitrary to group a subset of them within an object designed for selection.

Fixes #53
Fixes #52

All examples updated to match.

@wilaw wilaw requested a review from kixelated July 25, 2024 12:53
kixelated
kixelated approved these changes Jul 25, 2024
View reviewed changes
Copy link

@kixelated kixelated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler, thanks Will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kixelated kixelated kixelated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

commonTrackFields is a premature optimization Collapse selectionParams
2 participants
@wilaw @kixelated