Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNSUBSCRIBE is underspecified #363

Closed
ianswett opened this issue Feb 7, 2024 · 1 comment
Closed

UNSUBSCRIBE is underspecified #363

ianswett opened this issue Feb 7, 2024 · 1 comment
Labels
Needs Discussion Tags for issues which need discussion, ideally at an interim or IETF meeting. Subscribe Related to SUBSCRIBE message and subscription handling

Comments

@ianswett
Copy link
Collaborator

ianswett commented Feb 7, 2024 •
edited
Loading

UNSUBSCRIBE has some items I'd like clarified.

How do you know the last Group and Object that will be delivered? Do you get a SUBSCRIBE_RST or SUBSCRIBE_FIN? Or maybe we want to allow the UNSUBSCRIBE to specify that last Object it wants delivered, somewhat similar to a GOAWAY. We could also allow the subscriber to RST the SUBSCRIBE?

Or maybe we don't care about knowing the final Object?
@ianswett ianswett added the Subscribe Related to SUBSCRIBE message and subscription handling label Feb 7, 2024
@ianswett
Copy link
Collaborator Author

ianswett commented Feb 8, 2024

#269 concluded we want SUBSCRIBE_UPDATE, which is probably a better featureset than the current UNSUBSCRIBE anyway.

@mengelbart mengelbart mentioned this issue Feb 16, 2024
Open
ianswett added a commit that referenced this issue Feb 19, 2024
@ianswett
Replace UNSUBSCRIBE with SUBSCRIBE_UPDATE
5bd6be6 
Fixes #363 and #269
@ianswett ianswett mentioned this issue Feb 19, 2024
Closed
@ianswett ianswett removed the Needs PR label Feb 19, 2024
@ianswett ianswett added the Needs Discussion Tags for issues which need discussion, ideally at an interim or IETF meeting. label Mar 4, 2024
@ianswett ianswett closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion Tags for issues which need discussion, ideally at an interim or IETF meeting. Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SUBSCRIBE_UPDATE moq-wg/moq-transport
1 participant
@ianswett