Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANNOUNCE_CANCEL is missing a code/reason #412

Closed
kixelated opened this issue Mar 8, 2024 · 0 comments · Fixed by #522
Closed

ANNOUNCE_CANCEL is missing a code/reason #412

kixelated opened this issue Mar 8, 2024 · 0 comments · Fixed by #522
Assignees
@suhasHere
Labels
Announce Issues with Announce message and handling Needs PR Wire Format Related to how messages are serialized and parsed

Comments

@kixelated
Copy link
Collaborator

It's meant to be sent by the subscriber, indicating that the announce is no longer accepted. The fields should mirror ANNOUNCE_ERROR so the subscriber can indicate stuff like authentication expired, another announce was received, etc.
@ianswett ianswett added the Announce Issues with Announce message and handling label Mar 18, 2024
@afrind afrind added the Wire Format Related to how messages are serialized and parsed label Aug 6, 2024
@afrind afrind moved this to Needs PR in MoQT Tracking Board Aug 15, 2024
@suhasHere suhasHere mentioned this issue Sep 9, 2024
Merged
ianswett added a commit that referenced this issue Sep 16, 2024
@ianswett
Error code for announce cancel (#522)
a8ffcfe 
fixes #412
@github-project-automation github-project-automation bot moved this from Needs PR to Done in MoQT Tracking Board Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suhasHere suhasHere

Labels
Announce Issues with Announce message and handling Needs PR Wire Format Related to how messages are serialized and parsed
Projects
MoQT Tracking Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error code for announce cancel moq-wg/moq-transport
4 participants
@kixelated @suhasHere @afrind @ianswett