Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When should MAX_SUBSCRIBE be sent ? #572

Open
fluffy opened this issue Oct 1, 2024 · 2 comments
Open

When should MAX_SUBSCRIBE be sent ? #572

fluffy opened this issue Oct 1, 2024 · 2 comments
Assignees
@ianswett
Labels
Security/DoS Issues with MoQ's security or ways it may be vulnerable to denial of service / resource exhaustion Subscribe Related to SUBSCRIBE message and subscription handling

Comments

@fluffy
Copy link
Contributor

fluffy commented Oct 1, 2024

Do we need text that talks about when to send MAX_SUBSCRIBE. It defaults to zero and there does not seems to be normative text about using it.
@afrind
Copy link
Collaborator

afrind commented Oct 7, 2024

Individual Comment:

It's also a setup param, so each side can declare it's max before any subscriptions are sent. That said, some text about when to send this could be helpful.

Aside: Do we need a BLOCKED frame to inform the peer when you want to send a SUBSCRIBE but you are out of IDs? QUIC has these.

@afrind afrind added Subscribe Related to SUBSCRIBE message and subscription handling Security/DoS Issues with MoQ's security or ways it may be vulnerable to denial of service / resource exhaustion labels Oct 7, 2024
ianswett added a commit that referenced this issue Oct 28, 2024
@ianswett
Add SUBSCRIBES_BLOCKED
d41b8db 
Motivated by a comment on #572
@ianswett ianswett mentioned this issue Oct 28, 2024
Merged
ianswett added a commit that referenced this issue Nov 13, 2024
@ianswett
Add SUBSCRIBES_BLOCKED (#602)
9e2e281 
We said we might do this after adding MAX_SUBSCRIBE_ID, so here it is.

Motivated by a comment on #572
@ianswett
Copy link
Collaborator

ianswett commented Jan 8, 2025

We can base some text on https://datatracker.ietf.org/doc/html/rfc9000#flow-control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianswett ianswett

Labels
Security/DoS Issues with MoQ's security or ways it may be vulnerable to denial of service / resource exhaustion Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fluffy @afrind @ianswett