Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max Cache Duration per Subscription #450

Closed
wants to merge 2 commits into from
Closed

Max Cache Duration per Subscription #450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26233a4
Max Cache Duration per Subscription
ianswett May 22, 2024
edcb48d
Merge branch 'main' into ianswett-max-cache-duration
ianswett May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions draft-ietf-moq-transport.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1519,6 +1519,7 @@ SUBSCRIBE_OK
{
Subscribe ID (i),
Expires (i),
Max Cache Duration (i),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be slightly better as an optional parameter but clearly not a big deal either way

ContentExists (f),
[Largest Group ID (i)],
[Largest Object ID (i)]
Expand All @@ -1533,6 +1534,13 @@ longer valid. A value of 0 indicates that the subscription does not expire
or expires at an unknown time. Expires is advisory and a subscription can
end prior to the expiry time or last longer.

* Max Cache Duration: The maximum length of time in milliseconds a caching
relay MAY cache the subscription for. A value of 0 indicates there is no limit.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have value for non-relays (eg: subscriber side caches?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the objects that are cached not the subscription so I think this needs to say "MAY cache the object for"

The relay MUST NOT begin sending Objects for a new subscription from cache if
it's older than Max Cache Duration. When a relay responds with SUBSCRIBE_OK,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be clear the time starts at when the relay started to receive the object.

the amount of time since the corresponding upstream subscription was made is
subtracted when sending the Max Cache Duration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence does not make sense if we are caching objects not subscriptions. Would just remove it.


* ContentExists: 1 if an object has been published on this track, 0 if not.
If 0, then the Largest Group ID and Largest Object ID fields will not be
present.
Expand Down
Loading