-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MAX_CACHE_DURATION to SUBSCRIBE_OK Params #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Individual Review:
Do we need some language about what to do when an object is not in the cache?
Thanks @afrind , I added a sentence to clarify that, let me know if you'd like more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAX_CACHE_DURATION is a bit of a foot gun, especially if we find long groups in which objects depend on all preceding objects. Would be nice to have some nuance...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
draft-ietf-moq-transport.md
Outdated
|
||
The following property is defined in this document: | ||
|
||
MAX_CACHE_DURATION (key 0x01): An integer expressing a number of milliseconds. If |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should relays forward the parameter to downstream relays, and if so, what value should be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good .
A tweaked version of #448
Fixes #440
Fixes #249
Closes #450
Closes #448
I'll note that we might want to add params to TRACK_STATUS and allow this to be returned from that as well, which would allow a relay to keep it in its cache.
Attempts to write down where we ended up at the end of the June 12th interim.