Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Track Alias/Subscribe ID are a protocol violation #616

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

afrind
Copy link
Collaborator

@afrind afrind commented Nov 15, 2024

Fixes: #458

@ianswett ianswett added the Subscribe Related to SUBSCRIBE message and subscription handling label Dec 2, 2024
@martinduke
Copy link
Contributor

The lack of normative language is telling here. Killing a session because a subscriber has set its timer too short ("recently closed") is overkill and can lead to failures.

If the intent is to throw an error when there has not been a SUBSCRIBE or FETCH at all, then write that. If it's to throw an error when a SUBSCRIBE or FETCH has never been opened, then say the Sender MUST NOT do that, and the receiver SHOULD do a protocol error if it has the ability to detect that.

If it's to strictly ban the sending of data for any SUBSCRIBE/FETCH that has closed, it can be a MUST NOT for the sender, but I don't see how you can enforce that at the receiver except to reset the stream, because data can arrive arbitrarily late.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Subscribe Related to SUBSCRIBE message and subscription handling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Initialization Clarification with datagrams
3 participants