Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagram FETCH subgroup id=object ID #623

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Datagram FETCH subgroup id=object ID #623

merged 2 commits into from
Dec 2, 2024

Conversation

afrind
Copy link
Collaborator

@afrind afrind commented Nov 15, 2024

Fixes #600

ianswett
ianswett reviewed Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, since it resolves the issue, but I would think having all Datagrams in a Group have the same subgroup ID would indicate I should be sending them over a single stream? Making the subgroup ID the same as the Object ID is more in keeping with the SubGroup == Stream transmission model.

@ianswett ianswett added the Object Model Relating to the properties of Tracks, Groups and Object label Nov 19, 2024
@afrind
Copy link
Collaborator Author

afrind commented Nov 19, 2024

I'm fine with this, since it resolves the issue, but I would think having all Datagrams in a Group have the same subgroup ID would indicate I should be sending them over a single stream? Making the subgroup ID the same as the Object ID is more in keeping with the SubGroup == Stream transmission model.

Oh that makes more sense. Let's add this to the issue and see if others agree there.

@afrind afrind changed the title Datagram FETCH subgroup id=0 Datagram FETCH subgroup id=object ID Nov 22, 2024
@afrind
Copy link
Collaborator Author

afrind commented Nov 24, 2024

@suhasHere @martinduke you both approved when this PR set the value to 0 but I changed it. Please take another look.

ianswett
ianswett approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, since it resolves the issue, but I would think having all Datagrams in a Group have the same subgroup ID would indicate I should be sending them over a single stream? Making the subgroup ID the same as the Object ID is more in keeping with the SubGroup == Stream transmission model.

@ianswett ianswett merged commit 2049970 into main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinduke martinduke martinduke approved these changes

@ianswett ianswett ianswett approved these changes

@mengelbart mengelbart mengelbart approved these changes

@suhasHere suhasHere suhasHere approved these changes

Assignees
No one assigned
Labels
Object Model Relating to the properties of Tracks, Groups and Object
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What is the Subgroup ID of a Datagram FP object?
5 participants
@afrind @suhasHere @mengelbart @ianswett @martinduke