Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify SUBSCRIBE_UPDATE #653

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

ianswett
Copy link
Collaborator

This also fixes older text from when it was allowable to have multiple simultaneous subscriptions.

Fixes #576

This also fixes older text from when it was allowable to have multiple simultaneous subscriptions.

Fixes #576
Copy link
Collaborator

@afrind afrind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Individual Review

same or a later object than StartGroup and StartObject.
an existing subscription. Subscriptions can only become more narrow, not wider,
because an attempt to widen a subscription could fail. If Objects before the
start or after the end of the current subscription are needed, a fetch might
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/fetch/FETCH/ ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We refer to a subscription with lower case, so I'm not sure which is appropriate here?

draft-ietf-moq-transport.md Outdated Show resolved Hide resolved
Comment on lines 1351 to 1352
either rule or if the subscriber specifies a Subscribe ID that does not exist
within the Session.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Subscribe ID can also refer to a FETCH - so maybe "if it doesn't reference a current subscription"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing the session is dangerous -- if the publisher has sent SUBSCRIBE_DONE, it might have already tossed state for the subscribe ID

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do either of you have a suggestion on better phrasing or is the current text ok?

Copy link
Collaborator

@suhasHere suhasHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good . Agree with @afrind observations

Copy link
Collaborator Author

@ianswett ianswett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments

same or a later object than StartGroup and StartObject.
an existing subscription. Subscriptions can only become more narrow, not wider,
because an attempt to widen a subscription could fail. If Objects before the
start or after the end of the current subscription are needed, a fetch might
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We refer to a subscription with lower case, so I'm not sure which is appropriate here?

draft-ietf-moq-transport.md Outdated Show resolved Hide resolved
draft-ietf-moq-transport.md Outdated Show resolved Hide resolved
Comment on lines 1351 to 1352
either rule or if the subscriber specifies a Subscribe ID that does not exist
within the Session.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do either of you have a suggestion on better phrasing or is the current text ok?

@ianswett ianswett added the Editorial The draft is difficult to understand on a specific point, or it is open to multiple interpretations. label Jan 30, 2025
draft-ietf-moq-transport.md Outdated Show resolved Hide resolved
@ianswett ianswett merged commit 1dab1dc into main Feb 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial The draft is difficult to understand on a specific point, or it is open to multiple interpretations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not clear how OK and Errors work for SUBSCRIBE_UPDATE
4 participants