0.14 MessageId not limited to 65535

[hylkevds]

Expected behavior

Generated message IDs are, as per the MQTT specification, always in the 1 - 65535 range.

Actual behavior

Message IDs go over 65535.

Once the messages tick over, the ID in the packet loops back to 0, but the ID expected in ACKs is still > 65535, resulting in the messages never being ACKed. The only reason this was not noticeable was the messages were only re-sent once (causing memory leaks)

Steps to reproduce

Have a stream of QOS 1 or 2 messages go to a client, wait for 65535 messages to pass.

Minimal yet complete reproducer code (or URL to code) or complete log file

https://github.com/hylkevds/moquetteTests/

Moquette MQTT version

0.14

[supertick]

Hi,
I don't think this project is active ...
I had the same problem using moquette as an embedded broker ... solved it by changing netty config

      props.setProperty("netty.mqtt.message_size", "1048576");
      
      MemoryConfig mc = new MemoryConfig(props);
      Collections.singletonList(this);
      mqttBroker.startServer(mc, Collections.singletonList(this));

[hylkevds]

This issue is about the message Id not wrapping around back to 0 when hitting 65535, not about the size of the messages.