Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed server rendered root d# to d to allow google analytics to function for server rendered screens #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acetousk
Copy link
Member

Problem:
I was notified that some implementations of google analytics didn't work for the server rendered screens (specifically the checkout screen).

Possible Causes:

  1. A theory as to why this is is because of the # in the d screen
  2. Google Analytics doesn't allow for url fragments (# symbols in the url) in their tracking url by default, see here

Possible Solutions:

  1. This PR request will test to see if google analytics will still work for the checkouts screen despite vue-router adding
  2. Change google analytics settings to allow for segmented urls (see here)
  3. Change vue-router configuration to allow for not having segments (not sure how to do this, but might not be necessary)

Explanation:
I tried removing the # when trying to render using the vue-router and it made it so that the url is not https://.../d#/checkout/ but instead https://.../d/checkout#/. I didn't notice any functionality changes, and don't imagine that there would be functionality related to having a # in the url, but to test whether this is the problem. This would be a good way to test if this is the correct problem for getting google analytics to work.

Possible Drawbacks:
The url for server rendered screens is changed from https://.../d#/checkout/ to https://.../d/checkout#/. This shouldn't change functionality, but it might.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant