BugFix EntityListIterator not closed in NotificationMessageImpl#getNo…

…tifyUserIds
moqui · Nov 29, 2023 · 746d85c · 746d85c · jonesde · Nov 29, 2023
1 parent d82db61
commit 746d85c
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/framework/src/main/groovy/org/moqui/impl/context/NotificationMessageImpl.groovy b/framework/src/main/groovy/org/moqui/impl/context/NotificationMessageImpl.groovy
@@ -96,12 +96,16 @@ class NotificationMessageImpl implements NotificationMessage, Externalizable {
             EntityListIterator eli = ef.find("moqui.security.UserGroupMember")
                     .conditionDate("fromDate", "thruDate", new Timestamp(System.currentTimeMillis()))
                     .condition("userGroupId", userGroupId).disableAuthz().iterator()
-            EntityValue nextValue
-            while ((nextValue = (EntityValue) eli.next()) != null) {
-                String userId = (String) nextValue.userId
-                if (checkedUserIds.contains(userId)) continue
-                checkedUserIds.add(userId)
-                if (checkUserNotify(userId, ef)) notifyUserIds.add(userId)
+            try {
+                EntityValue nextValue
+                while ((nextValue = (EntityValue) eli.next()) != null) {
+                    String userId = (String) nextValue.userId
+                    if (checkedUserIds.contains(userId)) continue
+                    checkedUserIds.add(userId)
+                    if (checkUserNotify(userId, ef)) notifyUserIds.add(userId)
+                }
+            } finally {
+                eli.close();
             }
         }