Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of service-special when incorrect parameters are given. #583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve handling of service-special when incorrect parameters are given. #583

wants to merge 1 commit into from

Commits on May 8, 2023

  1. Improve handling of service-special when incorrect parameters are given. 

    When using service special, and parameters are given that do not pass
validation, moqui will attempt to log this.  However, doing so requires
an active transaction.  Service special runs this *after* the current
transaction has completed, so the validate logic fails to run, and a
NO_TRANSACTION message is printed instead, hiding the root cause of the
error.

So, now we implicitly validate the service call in beforeCompletion(),
so the current transaction will fail, and the root cause(incorrect
parameter specification) can be shown.
    @eigood
    eigood committed May 8, 2023
    Configuration menu
    Copy the full SHA
    345cd92 View commit details
    Browse the repository at this point in the history