Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime picker not working correctly in modal dialog when using custom format #40

Closed
mrovnanik opened this issue Jul 20, 2016 · 5 comments
Assignees

Comments

@mrovnanik
Copy link

mrovnanik commented Jul 20, 2016

The datetime picker in modal dialog works correctly, when custom format is not applied. When I set the format to custom, it stops working.

This one is not working:

image

image

This one is working: Format not defined.

image

image

@chunlinyao chunlinyao self-assigned this Jul 21, 2016
@jonesde
Copy link
Member

jonesde commented Jul 21, 2016

My guess is the JS date/time widget doesn't like the format string. You can view source to see what it is translated to, and my guess is there is an error on the JS console log in your browser.

This seems related to a more general issue:

moqui/moqui-framework#49

@chunlinyao
Copy link
Member

Found the reason, maybe a bug in datetimepicker, parseInputValue called before initFormatting, have a workaround.

@mrovnanik
Copy link
Author

I cannot reproduce the behavior, but I have used this custom format in datetimepicker maybe a month ago. I am pretty sure, because I was testing manual input (by typing directly into the textbox) of date on the very same screen.

@chunlinyao
Copy link
Member

It only occur when a string defaultDate and custom format set together.

mrovnanik added a commit to mrovnanik/moqui-runtime that referenced this issue Jul 21, 2016
Fix bug moqui#40 datetime picker not work when setting defaultDate with cu…
@mrovnanik
Copy link
Author

I see. Now it's working, I pulled your commit. Thanks very much, I am having a business meeting in an hour, this helps, because I can show the whole application right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants