Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix submit on select drop down where there is one result #219

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix submit on select drop down where there is one result #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
341cb57
Fix submit on select drop down where there is one result
acetousk Sep 27, 2023
c4d8f9f
Merge branch 'moqui:master' into drop-down-submit-on-select-1
acetousk Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base-component/webroot/screen/webroot/js/WebrootVue.qvt.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,7 +1685,7 @@ Vue.component('m-drop-down', {

// console.warn("curOptions updated " + this.name + " allowEmpty " + this.allowEmpty + " value '" + this.value + "' " + " isInNewOptions " + isInNewOptions + ": " + JSON.stringify(options));
if (!isInNewOptions) {
if (!this.allowEmpty && !this.multiple && options && options.length && options[0].value && (!this.requiredManualSelect || options.length === 1)) {
if (!this.allowEmpty && !this.multiple && options && options.length && options[0].value && (!this.requiredManualSelect || (!this.submitOnSelect && options.length === 1))) {
// simulate normal select behavior with no empty option (not allowEmpty) where first value is selected by default
// console.warn("checkCurrentValue setting " + this.name + " to " + options[0].value + " options " + options.length);
this.$emit('input', options[0].value);
Expand Down