Code needs update for newer OpenJPEG

[stweil]

Hello,

are there any plans to merge the code for OpenJPEG into https://github.com/ruven/iipsrv? I have a fork
https://github.com/stweil/iipsrv/tree/openjpeg based on your code, but updated for latest OpenJPEG and iipsrv (API changes). That fork only works partially (some JP2 files are shown, others result in a crash).

Regards,
Stefan Weil

[zabak]

Hi Stefan, currently, nobody is working on this. Could you please send me some of the files that crash?

[stweil]

@zabak: They no longer crash. The code now works, based on your code, latest iipsrv and latest OpenJPEG plus my modifications. It is currently about 100 times slower than iipsrv with Kakadu. I think that a large part of that huge difference is not caused by OpenJPEG, but by different handling of the conversion from JPEG 2000 to JPEG. See ruven/iipsrv#14 for details.

How could we get your code with my modifications into iipsrv, so that there is a common base for further improvements?

[zabak]

@stweil: Ruven promised to do it after he releases v.1.0 which he plans to do in the next few weeks.

[stweil]

PR ruven/iipsrv#61 merges your code with my updates for latest iipsrv.

[stweil]

@zabak, the files src/OpenJPEG.cc and src/OpenJPEG.h don't include a copyright statement or a license. Do those files use GPL3 (the default license for iipsrv)? Should I add a copyright for your library to my pull request?

[zabak]

Yes please.

[stweil]

Then I'll add the text below to both files. Please confirm or tell me any modifications which you want.

Copyright (C) 2015 Moravian Library in Brno (http://www.mzk.cz/)

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <http://www.gnu.org/licenses/>.

[zabak]

The text is OK.