Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide ToDictionary() in net8+ #1040

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Hide ToDictionary() in net8+ #1040

merged 5 commits into from
Nov 20, 2023

Conversation

viceroypenguin
Copy link
Contributor

@viceroypenguin viceroypenguin commented Nov 15, 2023

This PR updates ToDictionary() to be hidden on net8, since the BCL has added a duplicate method.

Fixes #1012
Relates to #945

Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #1041 is merged with 9a4ea61, can we resolve the conflicts so there's a smaller diff to review? Thanks!

@viceroypenguin
Copy link
Contributor Author

Now that #1041 is merged with 9a4ea61, can we resolve the conflicts so there's a smaller diff to review? Thanks!

Done!

Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Thanks, though the build is broken. Could you have a look?

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a4ea61) 92.62% compared to head (c9144e4) 92.52%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
- Coverage   92.62%   92.52%   -0.11%     
==========================================
  Files         113      113              
  Lines        3419     3413       -6     
  Branches     1055     1058       +3     
==========================================
- Hits         3167     3158       -9     
  Misses        189      189              
- Partials       63       66       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@atifaziz atifaziz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help with this!


PS I reverted some unrelated formatting changes with c9144e4, but I would appreciate it if you can avoid them in the first place in your PRs; it really helps with reducing the review time. Thanks.

@atifaziz atifaziz merged commit c349f1d into morelinq:master Nov 20, 2023
3 of 4 checks passed
@viceroypenguin viceroypenguin deleted the todictionary branch November 20, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide ToDictionary() in net8+
2 participants