-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide ToDictionary()
in net8+
#1040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Thanks, though the build is broken. Could you have a look?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
- Coverage 92.62% 92.52% -0.11%
==========================================
Files 113 113
Lines 3419 3413 -6
Branches 1055 1058 +3
==========================================
- Hits 3167 3158 -9
Misses 189 189
- Partials 63 66 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your help with this!
PS I reverted some unrelated formatting changes with c9144e4, but I would appreciate it if you can avoid them in the first place in your PRs; it really helps with reducing the review time. Thanks.
This PR updates
ToDictionary()
to be hidden on net8, since the BCL has added a duplicate method.Fixes #1012
Relates to #945