Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set simple field naming rules with this qualifier #1050

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

atifaziz
Copy link
Member

@atifaziz atifaziz commented Nov 19, 2023

There was a time when prefixing field names with underscore (_) aided in visual inspection and avoided accidents from ambiguity, but static code analysers have changed the game and primary constructors have blurred the lines further so this PR:

  • sets the rules for field names to be simple and without the underscore
  • requires this qualification for fields
  • makes it consistent for entire code base and enforces the rules to maintain the consistency

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (3de8b3f) 92.50% compared to head (2024e82) 92.50%.

Files Patch % Lines
MoreLinq/Reactive/Subject.cs 76.92% 2 Missing and 1 partial ⚠️
MoreLinq/CollectionLike.cs 66.66% 0 Missing and 2 partials ⚠️
MoreLinq/Delegating.cs 60.00% 0 Missing and 2 partials ⚠️
MoreLinq/ListLike.cs 71.42% 0 Missing and 2 partials ⚠️
MoreLinq/ReverseComparer.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1050   +/-   ##
=======================================
  Coverage   92.50%   92.50%           
=======================================
  Files         112      112           
  Lines        3401     3403    +2     
  Branches     1056     1056           
=======================================
+ Hits         3146     3148    +2     
  Misses        189      189           
  Partials       66       66           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atifaziz atifaziz merged commit 2024e82 into morelinq:master Nov 19, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant