-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return implementation #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR! I've conducted a first review. It's a good start but what I found missing most were tests for all the members of the list returned by Return
.
Co-Authored-By: Atif Aziz <code@raboof.com>
Co-Authored-By: Atif Aziz <code@raboof.com>
Co-Authored-By: Atif Aziz <code@raboof.com>
Co-Authored-By: Atif Aziz <code@raboof.com>
TestContainsReturnsTrueWhenTheResultingSequenceContainsTheItemProvided TestContainsDoesNotThrowWhenTheItemContainedIsNull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through all changes from the previous review very promptly. This is a quick review for now with only a since issue that needs addressing.
TestIndexOfDoesNotThrowWhenTheItemContainedIsNull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all those tests! Looking much better and I think we are nearly there. 🏁
Also, could I ask you to add Return
to the operators list in README.md
and the project/package description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beginning to really take up shape! Thanks for all those well-reading tests! There are just a few edits left now and then we're good to go with this!
I took the liberty to make a change myself with 236daef as it would have been too painful to describe in words. 😄 It associates the test cases with the test so this is how they appear named and organised:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MitchBodmer for working through the review and contributing this in the first place! Looking good to ship now! 🎉
PS I might make some minor formatting changes before merging.
@atifaziz |
Here's a first go at the Return method. #615