Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return value docs for MinBy/MaxBy #765

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

atifaziz
Copy link
Member

This PR fixes issue #764.

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #765 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #765   +/-   ##
=======================================
  Coverage   88.70%   88.70%           
=======================================
  Files         108      108           
  Lines        3470     3470           
  Branches      978      978           
=======================================
  Hits         3078     3078           
  Misses        251      251           
  Partials      141      141           
Impacted Files Coverage Δ
MoreLinq/MaxBy.cs 91.81% <ø> (ø)
MoreLinq/MinBy.cs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2acece8...712ace4. Read the comment docs.

@atifaziz atifaziz merged commit e384ba0 into morelinq:master Oct 29, 2020
@atifaziz atifaziz deleted the minby-maxby-retval-doc branch October 29, 2020 07:40
@atifaziz atifaziz linked an issue Oct 29, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Min/MaxBy documented return type incorrectly mentions singular value
1 participant