Skip to content

Conversation

chfw
Copy link
Member

@chfw chfw commented Dec 1, 2019

Before raising the PR, here is a check list:

  • have you written unit tests for your code changes?
  • have you updated the change log?
  • can someone else understand your changes without your explanation?
  • are you proud of your code changes?
  • please add your name and github link to contributors.rst in alphabetical order.

delivers #351

@codecov-io
Copy link

codecov-io commented Dec 1, 2019

Codecov Report

Merging #352 into dev will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev    #352      +/-   ##
=========================================
+ Coverage   96.29%   96.3%   +0.01%     
=========================================
  Files          55      55              
  Lines        2804    2814      +10     
=========================================
+ Hits         2700    2710      +10     
  Misses        104     104
Impacted Files Coverage Δ
moban/plugins/jinja2/engine.py 100% <100%> (ø) ⬆️
moban/main.py 100% <100%> (ø) ⬆️
moban/core/moban_factory.py 98.07% <100%> (+0.02%) ⬆️
moban/plugins/copy.py 100% <100%> (ø) ⬆️
moban/externals/reporter.py 95.91% <100%> (ø) ⬆️
tests/test_reporter.py 100% <100%> (ø) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dae1d9...60a1e61. Read the comment docs.

@chfw chfw merged commit 053b242 into dev Dec 1, 2019
@chfw chfw deleted the template-plugin-name branch December 1, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants