Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new Arch #739

Merged

Conversation

hoanghai9650
Copy link
Contributor

Migrate library to new Arch of React Native.

@jannisringwald
Copy link

I'm getting the Error while building you Branch:

Undefined symbols for architecture arm64: "_OBJC_CLASS_$_CNContactViewController", referenced from: in react_native_contacts[3](RCTContacts.o) ld: symbol(s) not found for architecture arm64

@hoanghai9650
Copy link
Contributor Author

Screenshot 2024-05-21 at 17 05 32 Have you set arm64 in excluded Architectures in Build Settings?

@morenoh149
Copy link
Owner

@hoanghai9650 thanks for this. Does this close #736 ?

@hoanghai9650
Copy link
Contributor Author

@morenoh149 Yes, this PR will close that issue

@mym0404
Copy link

mym0404 commented May 27, 2024

@hoanghai9650 why should we exclude arm64 architecture? It seems not an idle solution.

@hoanghai9650
Copy link
Contributor Author

@mym0404 As you can see in my code, I didn't config or enable any arm64, but don't know why this new arch required that, I think because of new Spec of React Native. But with all libs that I migrated to new arch, I also have to enable arm64 to make it run.

@mym0404
Copy link

mym0404 commented May 27, 2024

It makes sense. But, the build will success with manually add Contacts apple sdk in app target.

I'll further investigate why new arch made change.

Copy link

This Pull request is stale, please review.

@morenoh149
Copy link
Owner

@hoanghai9650 new conflicts

@SolankiYogesh3500
Copy link

new update on this guys ?

@faljabi
Copy link

faljabi commented Sep 17, 2024

Hi,

When this will be merged? app is crashing for new Arch.

@morenoh149 morenoh149 merged commit ee74e0e into morenoh149:master Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants