Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix copying filters for e2t messages and conditional redirects. #122

Open
wants to merge 4 commits into
base: 7.x-2.x
Choose a base branch
from

Conversation

torotil
Copy link
Contributor

@torotil torotil commented Jun 29, 2018

This fixes a bug where filters were removed from one message/redirect
when they were copied to another (and their id was kept).

torotil and others added 2 commits June 29, 2018 10:38
This fixes a bug where filters were removed from one message/redirect
when they were copied to another.
@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #122 into 7.x-2.x will increase coverage by 0.14%.
The diff coverage is 87.5%.

Impacted file tree graph

@@              Coverage Diff              @@
##             7.x-2.x     #122      +/-   ##
=============================================
+ Coverage      40.92%   41.07%   +0.14%     
- Complexity      1744     1746       +2     
=============================================
  Files            274      274              
  Lines           9939     9942       +3     
  Branches         154      154              
=============================================
+ Hits            4068     4084      +16     
+ Misses          5868     5850      -18     
- Partials           3        8       +5
Impacted Files Coverage Δ Complexity Δ
...rd/redirects_app/src/components/RedirectDialog.vue 0% <0%> (ø) 0 <0> (ø) ⬇️
campaignion_email_to_target/src/Filter.php 89.47% <100%> (+0.38%) 20 <0> (ø) ⬇️
..._target/messages_app/src/components/SpecDialog.vue 38.46% <100%> (+18.98%) 0 <0> (ø) ⬇️
campaignion_action/src/Redirects/Filter.php 87.34% <100%> (-0.16%) 31 <0> (ø)
campaignion_action/src/Redirects/Redirect.php 95.69% <100%> (ø) 37 <0> (+1) ⬆️
...ampaignion_email_to_target/src/MessageTemplate.php 93.02% <100%> (ø) 33 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e61721f...3ac7252. Read the comment docs.

@torotil torotil changed the base branch from 7.x-1.x to 7.x-2.x November 23, 2018 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants