Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow headless nightwatch tests #134

Open
wants to merge 1 commit into
base: 7.x-2.x
Choose a base branch
from
Open

Conversation

alex-mo
Copy link
Contributor

@alex-mo alex-mo commented Oct 1, 2018

redirects_app: run tests with HEADLESS=1 yarn e2e for headless browser

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #134 into 7.x-1.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             7.x-1.x    #134   +/-   ##
=========================================
  Coverage       35.4%   35.4%           
  Complexity      1674    1674           
=========================================
  Files            228     228           
  Lines           8626    8626           
=========================================
  Hits            3054    3054           
  Misses          5572    5572

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faa75e3...8840b9a. Read the comment docs.

@torotil
Copy link
Contributor

torotil commented Oct 15, 2018

Tests fail for me in this branch if I invoke them as described.

@torotil torotil changed the base branch from 7.x-1.x to 7.x-2.x November 23, 2018 10:06
@alex-mo
Copy link
Contributor Author

alex-mo commented Dec 13, 2018

how do they fail? (because for me the tests are all green. I only had issues getting selenium to work, but the HEADLESS env should be fixing this...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants