Donation amount component #248
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7.x-2.x #248 +/- ##
=============================================
+ Coverage 46.58% 46.85% +0.26%
+ Complexity 1827 1823 -4
=============================================
Files 287 285 -2
Lines 10144 10225 +81
Branches 154 154
=============================================
+ Hits 4726 4791 +65
- Misses 5415 5431 +16
Partials 3 3
Continue to review full report at Codecov.
|
torotil
force-pushed
the
donation-amount-component
branch
3 times, most recently
from
31fef67
to
b3af0e6
Compare
alex-mo
reviewed
Oct 6, 2020
| $defaults['extra'] += [ | ||
| 'options' => [], | ||
| 'other_option' => TRUE, | ||
| 'other_text' => t('Other'), |
There was a problem hiding this comment.
Why not "Other amount"? Seems a better fit as it can only be another amount, not another "something".
alex-mo
reviewed
Oct 6, 2020
alex-mo
reviewed
Oct 6, 2020
| if ($component['extra']['options']) { | ||
| $element['#type'] = 'select_or_other'; | ||
| $element['#select_type'] = 'radios'; | ||
| $element['#options'] = drupal_map_assoc($component['extra']['options']); |
There was a problem hiding this comment.
Would be great if we can toggle whether the currency symbol gets prepended before the amount. This is a very common use case in rendering. (Just rendering it an hiding via styles would work too)
The currency symbol would be best wrapped in a span with an appropriate class...
alex-mo
reviewed
Oct 6, 2020
| $element['#type'] = 'select_or_other'; | ||
| $element['#select_type'] = 'radios'; | ||
| $element['#options'] = drupal_map_assoc($component['extra']['options']); | ||
| $element['#other'] = !empty($component['extra']['other_text']) ? check_plain($component['extra']['other_text']) : t('Other...'); |
There was a problem hiding this comment.
Same as above: why not "Other amount"?
torotil
force-pushed
the
donation-amount-component
branch
from
435f289
to
6002b28
Compare
torotil
force-pushed
the
donation-amount-component
branch
from
6002b28
to
65cf1b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim is to improve the usability of configuring donation amount components. In order to do this we add a new customized webform component.