New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BufferUtils.ensureCapacity now clears the input buffer #63

Closed

dweiss opened this issue Sep 9, 2015 · 0 comments

Assignees

Labels

Milestone

Member

dweiss commented Sep 9, 2015

It'd be better to check for remaining space in the buffer and not require buffers to be at position() == 0

dweiss added the refactoring label

dweiss self-assigned this

dweiss added this to the 2.1.0 milestone

dweiss changed the title ~~BufferUtils.ensureCapacity doesn't make much sense~~ BufferUtils.ensureCapacity now clears the input buffer

dweiss closed this as completed in

f9592c5

dweiss added a commit that referenced this issue


          GH-63: follow-up off by one fix.

241df1d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment