-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functional tests #203
Functional tests #203
Conversation
Alright, looks funtests hang on Windows. I'm gonna fix that later. |
Feel free to ask me if you need any help. |
@ForNeVeR sure! Thank you! |
Alright, it's been already more than a week. I'm gonna submit what I've already done and split out the Windows funtests support. |
This is interesting. The result of REPL funtests heavily depends on the terminal implementation on Linux. I observed different results on gnome-terminal and Emacs. It's probably caused by jline. I'm gonna split out REPL funtests support too. |
class FibFuntest extends FlatSpec with Matchers { | ||
"15 first fibonacci numbers sample" should "print 15 first fibonacci numbers" in { | ||
val expectedOutput = "numbers: [0,1,1,2,3,5,8,13,21,34,55,89,144,233,377]\n" | ||
val actualOutput = "java -jar ./target/scala-2.11/morganey.jar ./docs/samples/fib.mgn".!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend to factor this out into a function or a constant, to remove the duplication of "java -jar ./target/scala-2.11/morganey.jar"
everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides @ForNeVeR's suggested improvement; LGTM 👍
Description
Since I'm really bad at sbt, my funtests infrastructure implementation probably could be better. Please provide your remarks when you get a chance.
Split out pieces
Checklist
Split #55