refactor: remove jsx-runtime from hook and highlighter. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
morganney
commented
Jul 21, 2024
•
morganney
commented
- use new pkg for react 19 types until stable release.
- remove UMD example from docs, update CDN / importmap example.
morganney
commented
Jul 21, 2024
|
|
||
| createRoot(document.getElementById('root')).render( | ||
| html` |
There was a problem hiding this comment.
htm package didn't seem to provide a way to use React 19.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 98.25% 98.26%
=======================================
Files 7 7
Lines 573 575 +2
Branches 146 146
=======================================
+ Hits 563 565 +2
Misses 10 10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.