Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic layout persistence implementation. #755

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

fhubi
Copy link
Member

@fhubi fhubi commented Aug 29, 2024

As we discussed, the shell will decide how it would like to serialize and deserialize layout data and the layout data is also depends on the shell.

  • Added the necessary interfaces
  • Added FileLayoutPersistance
  • Added json and xml serializer/deserializer

@fhubi fhubi requested a review from a team as a code owner August 29, 2024 13:47
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.78%. Comparing base (dd3817e) to head (04259c3).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
...outPersistence/Serializers/JsonLayoutSerializer.cs 71.42% 2 Missing and 2 partials ⚠️
...youtPersistence/Serializers/XmlLayoutSerializer.cs 78.94% 2 Missing and 2 partials ⚠️
...mposeUI.LayoutPersistence/FileLayoutPersistence.cs 93.54% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
+ Coverage   67.63%   67.78%   +0.14%     
==========================================
  Files         261      264       +3     
  Lines        7997     8061      +64     
  Branches      894      858      -36     
==========================================
+ Hits         5409     5464      +55     
- Misses       2400     2405       +5     
- Partials      188      192       +4     
Files with missing lines Coverage Δ
...mposeUI.LayoutPersistence/FileLayoutPersistence.cs 93.54% <93.54%> (ø)
...outPersistence/Serializers/JsonLayoutSerializer.cs 71.42% <71.42%> (ø)
...youtPersistence/Serializers/XmlLayoutSerializer.cs 78.94% <78.94%> (ø)

... and 1 file with indirect coverage changes

@fhubi fhubi merged commit 7c89122 into morganstanley:main Sep 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants