-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic layout persistence implementation. #755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztanczos
reviewed
Aug 29, 2024
...ence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/Abstractions/ILayoutPersistence.cs
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Aug 29, 2024
...tence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/Abstractions/ILayoutSerializer.cs
Outdated
Show resolved
Hide resolved
lilla28
reviewed
Aug 29, 2024
...ersistence/dotnet/tests/MorganStanley.ComposeUI.LayoutPersistence.Tests/LayouManagerTests.cs
Outdated
Show resolved
Hide resolved
...ence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/Abstractions/ILayoutPersistence.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 67.63% 67.78% +0.14%
==========================================
Files 261 264 +3
Lines 7997 8061 +64
Branches 894 858 -36
==========================================
+ Hits 5409 5464 +55
- Misses 2400 2405 +5
- Partials 188 192 +4
|
ztanczos
reviewed
Sep 2, 2024
...ut-persistence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/FileLayoutPersistence.cs
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Sep 2, 2024
...ut-persistence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/FileLayoutPersistence.cs
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Sep 2, 2024
...ence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/Serializers/XmlLayoutSerializer.cs
Outdated
Show resolved
Hide resolved
ZKRobi
reviewed
Sep 3, 2024
...ut-persistence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/FileLayoutPersistence.cs
Outdated
Show resolved
Hide resolved
ZKRobi
reviewed
Sep 3, 2024
src/layout-persistence/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/LayoutManager.cs
Outdated
Show resolved
Hide resolved
ZKRobi
reviewed
Sep 3, 2024
...ce/dotnet/tests/MorganStanley.ComposeUI.LayoutPersistence.Tests/JsonLayoutSerializerTests.cs
Outdated
Show resolved
Hide resolved
ZKRobi
reviewed
Sep 3, 2024
...nce/dotnet/tests/MorganStanley.ComposeUI.LayoutPersistence.Tests/XmlLayoutSerializerTests.cs
Show resolved
Hide resolved
psmulovics
reviewed
Sep 3, 2024
...nce/dotnet/src/MorganStanley.ComposeUI.LayoutPersistence/Serializers/JsonLayoutSerializer.cs
Show resolved
Hide resolved
ZKRobi
approved these changes
Sep 5, 2024
ztanczos
approved these changes
Sep 5, 2024
lilla28
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed, the shell will decide how it would like to serialize and deserialize layout data and the layout data is also depends on the shell.