Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for fdc3.open() #790

Open
wants to merge 2 commits into
base: feat/fdc3-2_0-conformance
Choose a base branch
from

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Sep 30, 2024

Fixed:

  • Fixed existing unit tests in our projects
  • Removed added console.logs() for debugging purpose

Changed:

  • Added unit tests in .Net and Typescript sides for fdc3.open call
  • Improvements around caching the contexts -if the opened app's right context listener is not resolved the context received via the fdc3.open call we cache all the contexts until that context is resolved

Question: should we stop the module via module loader if the request fails but the start of the app was succesful? (e.g. context listener is not registered so AppTimeout happens) -> Conformance framework tests are closing the window if the request fails in this case.

@lilla28 lilla28 marked this pull request as ready for review October 2, 2024 11:13
@lilla28 lilla28 requested a review from a team as a code owner October 2, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant