Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial click in inactive window is lost #24

Closed
morgant opened this issue Aug 4, 2021 · 2 comments
Closed

Initial click in inactive window is lost #24

morgant opened this issue Aug 4, 2021 · 2 comments
Labels
Milestone

Comments

@morgant
Copy link
Owner

morgant commented Aug 4, 2021

When clicking on a control within an inactive window, the window is made active, but the click on the control is lost. This requires an additional click from the user and can be confusing as to why the initial click didn't register.

@morgant morgant added the bug label Aug 4, 2021
@morgant morgant added this to the 0.9.4 milestone Sep 3, 2021
@morgant
Copy link
Owner Author

morgant commented Sep 5, 2021

In event.c's handle_button_press(), I was able to tweak whether XAllowEvents() gets called with AsyncPointer or ReplayPointer depending on whether the click was in an inactive window or not. This allowed me to pass the original click event through.

I'm currently debugging adding a SwallowFocusClick config option to make it conditional.

morgant added a commit that referenced this issue Sep 9, 2021
…inactive windows, plus added 'SwallowFocusClick' config command to disable the functionality. Issue #24
@morgant
Copy link
Owner Author

morgant commented Sep 9, 2021

I discovered a bug in config file parsing which would incorrectly match config commands that were partial matches of other config commangs. I was able to fix this and make the config parsing more robust.

I have now committed the handle_button_press() improvements and the new SwallowFocusClick config command, plus updated the manual page. So this is all set.

@morgant morgant closed this as completed Sep 9, 2021
morgant added a commit that referenced this issue Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant