Merge pull request #9 from moricho/fix/without-subtests

No warning when a top level test has no subtests
moricho · Sep 21, 2020 · 88fabab · 88fabab
2 parents a9ada19 + 0f9552b
commit 88fabab
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/testdata/src/test/without_sub_test.go b/testdata/src/test/without_sub_test.go
@@ -0,0 +1,10 @@
+package test
+
+import (
+	"testing"
+)
+
+func TestWithoutSub(t *testing.T) { // OK
+	t.Parallel()
+	call("TestWithoutSub")
+}
diff --git a/tparallel.go b/tparallel.go
@@ -40,6 +40,9 @@ func run(pass *analysis.Pass) (interface{}, error) {
 
 	testMap := getTestMap(ssaanalyzer, testTyp) // ex. {Test1: [TestSub1, TestSub2], Test2: [TestSub1, TestSub2, TestSub3], ...}
 	for top, subs := range testMap {
+		if len(subs) == 0 {
+			continue
+		}
 		isParallelTop := ssafunc.IsCalled(top, parallel)
 		isPararellSub := false
 		for _, sub := range subs {