Skip to content
This repository has been archived by the owner on Oct 29, 2021. It is now read-only.

Some searches hitting 300-section limit in updateTimetables #39

Open
BillyBolton opened this issue May 21, 2019 · 4 comments
Open

Some searches hitting 300-section limit in updateTimetables #39

BillyBolton opened this issue May 21, 2019 · 4 comments
Assignees
Labels

Comments

@BillyBolton
Copy link

The PHY 1000 courses are not showing up for me either. (I'm specifically looking for course PHY1331). Would you mind trying to update the courses again to see if this works? I see them in the saved CVS sheets but I'm not sure why it's not posting anymore.

Screen Shot 2019-05-21 at 5 12 37 PM

Screen Shot 2019-05-21 at 5 10 52 PM

Screen Shot 2019-05-21 at 5 10 30 PM

Additionally, it looks like I can't connect to the server anymore. Is there a solution to this too?

Screen Shot 2019-05-21 at 5 14 17 PM

@davidschlachter
Copy link
Collaborator

As you can see in the csv files, the course is listed there for the summer semester (20195). The issue is that first-year physics courses in the Fall and Winter semesters are currently returning more than the limit of 300 sections in the course search tool. I'll try to figure this out by Friday but it will probably just involve detecting that the limit is being reached in the search, then using more restrictive search criteria to ensure that the sections can be returned.

Capture d’écran, le 2019-05-21 à 22 14 16

@davidschlachter
Copy link
Collaborator

(The connection issue was due to a corrupted statistics file, seems to happen about once every year or two)

@davidschlachter davidschlachter changed the title Some courses not showing and cannot connect to server Some searches hitting 300-section limit in updateTimetables May 22, 2019
@davidschlachter davidschlachter self-assigned this May 22, 2019
davidschlachter added a commit that referenced this issue May 22, 2019
There are still some searches that will hit the 300-section limit (e.g. PHY Winter 2020 1st year EN), but iterating over language of instruction gets us below the limit in several other cases.
@BillyBolton
Copy link
Author

Awesome, thanks for looking into this!

@davidschlachter
Copy link
Collaborator

davidschlachter commented May 24, 2019

First year Physics courses are now in the database for the Fall semester, but for the Winter we're still hitting the section limit. I'll need to change the approach used for recursion in updateTimetables.py, a full fix is coming but no ETA at the moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants