feat: lambda snap_start argument #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzzimmer
requested changes
Nov 15, 2023
Owner
moritzzimmer
left a comment
moritzzimmer
left a comment
There was a problem hiding this comment.
thanks for the PR @dimitriydotsenko. I've made some suggestions for naming and simplifying things.
Since snap start is also relying on the published version of a function, we might also need to set local.publish to true if it's either an Edge Lambda or using snap start.
Co-authored-by: Moritz Zimmer <moritzzimmer@users.noreply.github.com>
moritzzimmer
approved these changes
Nov 17, 2023
Owner
moritzzimmer
left a comment
moritzzimmer
left a comment
There was a problem hiding this comment.
awesome, thx for the contribution @dimitriydotsenko
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
works only with Java runtime and only on x86 architecture, more info in aws docs