feat: refactor iam roles to remove inline_policy deprecation warning #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcel2603
changed the title
Marcel2603
changed the title
moritzzimmer
requested changes
Jan 7, 2025
Owner
moritzzimmer
left a comment
moritzzimmer
left a comment
There was a problem hiding this comment.
Nice work @Marcel2603!
While we're at it - could you please use aws_iam_policy_document instead of jsonencode at all places where a policy or assume_role_policy value is assigned
moritzzimmer
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inline_policy of aws_iam_role is deprecated https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role
We receive multiple terraform warnings on each tf apply. For this reason, i've moved all inline_policies to
aws_iam_role_policy.On first tf apply, there will be 6 new resources of type
aws_iam_role_policy. You will not see any difference in the aws iam role.