Skip to content

Conversation

@moritzzimmer
Copy link
Owner

This PR adds support for event source mapping metrics, see aws docs for details

@moritzzimmer moritzzimmer self-assigned this Sep 11, 2025
@moritzzimmer moritzzimmer added the 💅 enhancement New feature or request label Sep 11, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for AWS Lambda event source mapping metrics configuration, allowing users to specify which metrics to collect for their event source mappings as documented in the AWS Lambda monitoring guide.

  • Adds metrics_config dynamic block to the event source mapping resource
  • Updates example configurations to demonstrate metrics_config usage with EventCount metric
  • Reorganizes scaling_config placement in the SQS example for better readability

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
event_source_mappings.tf Adds dynamic metrics_config block to aws_lambda_event_source_mapping resource
examples/with-event-source-mappings/sqs/main.tf Demonstrates metrics_config usage and reorganizes scaling_config placement
examples/with-event-source-mappings/kinesis/main.tf Adds metrics_config example with EventCount metric
examples/with-event-source-mappings/dynamodb-with-alias/main.tf Adds metrics_config example and removes empty line

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@moritzzimmer moritzzimmer merged commit cfdfc41 into main Sep 11, 2025
9 checks passed
@moritzzimmer moritzzimmer deleted the feat/esm_metrics_config branch September 11, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💅 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants