Skip to content

feat: add input argument for cloudwatch_event_target #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 29, 2022
Merged

feat: add input argument for cloudwatch_event_target #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bdbeeda
feat: add input argument for cloudwatch_event_target
ablotny Sep 28, 2022
2cbd5bd
Merge branch 'master' into target_input
moritzzimmer Sep 29, 2022
f41f4c8
docs: update README template and example
ablotny Sep 29, 2022
a1e0c0a
Merge remote-tracking branch 'origin/target_input' into target_input
ablotny Sep 29, 2022
1b8cd6f
documentation: provider version
moritzzimmer Sep 29, 2022
db9fe6c
fix: fmt
moritzzimmer Sep 29, 2022
0855fa3
documentation: updated provider version
moritzzimmer Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ module "lambda" {

// optionally overwrite `cloudwatch_event_target_arn` in case an alias should be used for the event rule
cloudwatch_event_target_arn = aws_lambda_alias.example.arn

// optionally add `cloudwatch_event_target_input` for event input
Copy link
Owner

@moritzzimmer moritzzimmer Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the README.md is generated, could you please add this to docs/part1.md and run make documentation

Please also add this to the example in

terraform-aws-lambda/examples/with-cloudwatch-event-rules/main.tf

Line 29 in f195d88

cloudwatch_event_target_arn = aws_lambda_alias.example.arn

cloudwatch_event_target_input = jsonencode({"key": "value"})
}

pattern = {
Expand Down
5 changes: 3 additions & 2 deletions cloudwatch_event_rules.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ resource "aws_cloudwatch_event_rule" "lambda" {
resource "aws_cloudwatch_event_target" "lambda" {
for_each = var.cloudwatch_event_rules

arn = lookup(each.value, "cloudwatch_event_target_arn", local.function_arn)
rule = aws_cloudwatch_event_rule.lambda[each.key].name
arn = lookup(each.value, "cloudwatch_event_target_arn", local.function_arn)
rule = aws_cloudwatch_event_rule.lambda[each.key].name
input = lookup(each.value, "cloudwatch_event_target_input", null)
}
3 changes: 2 additions & 1 deletion docs/deployment/part2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | 3.67.0 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 4.9 |

## Modules

Expand All @@ -36,6 +36,7 @@ No modules.
| [aws_iam_role.trigger](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
| [aws_iam_role_policy_attachment.codedeploy](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_s3_bucket.pipeline](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
| [aws_s3_bucket_acl.pipeline](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |
| [aws_s3_bucket_policy.cloudtrail](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_policy) | resource |
| [aws_s3_bucket_public_access_block.source](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_public_access_block) | resource |
| [aws_sns_topic.notifications](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sns_topic) | resource |
Expand Down
3 changes: 3 additions & 0 deletions docs/part1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ module "lambda" {

// optionally overwrite `cloudwatch_event_target_arn` in case an alias should be used for the event rule
cloudwatch_event_target_arn = aws_lambda_alias.example.arn

// optionally add `cloudwatch_event_target_input` for event input
cloudwatch_event_target_input = jsonencode({"key": "value"})
}

pattern = {
Expand Down
5 changes: 4 additions & 1 deletion examples/with-cloudwatch-event-rules/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ module "lambda" {

// optionally overwrite `cloudwatch_event_target_arn` in case an alias should be used for the event rule
cloudwatch_event_target_arn = aws_lambda_alias.example.arn

// optionally add `cloudwatch_event_target_input` for event input
cloudwatch_event_target_input = jsonencode({ "key" : "value" })
}

pattern = {
Expand All @@ -39,4 +42,4 @@ module "lambda" {
PATTERN
}
}
}
}
3 changes: 2 additions & 1 deletion modules/deployment/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ resource "aws_s3_bucket_object" "source" {

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | 3.67.0 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 4.9 |

## Modules

Expand All @@ -200,6 +200,7 @@ No modules.
| [aws_iam_role.trigger](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role) | resource |
| [aws_iam_role_policy_attachment.codedeploy](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/iam_role_policy_attachment) | resource |
| [aws_s3_bucket.pipeline](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket) | resource |
| [aws_s3_bucket_acl.pipeline](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_acl) | resource |
| [aws_s3_bucket_policy.cloudtrail](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_policy) | resource |
| [aws_s3_bucket_public_access_block.source](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_public_access_block) | resource |
| [aws_sns_topic.notifications](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/sns_topic) | resource |
Expand Down