Add iam_role_name override variable and ensure generated name does not exceed 64 chars #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure generated role name does not exceed 64 characters by falling back to hash256
moritzzimmer
requested changes
Nov 2, 2022
There was a problem hiding this comment.
@BrandonLWhite thx for this PR! I would change the name generation a bit, otherwise 👍
|
@BrandonLWhite what do you think about the proposed changes? |
|
Sure, no problem. I will try to get a commit with the changes today. |
Use coalesce function
moritzzimmer
approved these changes
Nov 9, 2022
|
this has been released with v6.6.0 - thx for the contribution @BrandonLWhite! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two things related to the IAM role name:
iam_role_nameinput variable.This is backward compatible because the default is the generated name, same as before. Further, no existing generated name could have exceeded 64 characters therefore the hash fallback will not affect existing projects.
I'm having difficulty executing the tests, otherwise I would most certainly add to the test coverage.