fix: add event bus name to cloudwatch event targets. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottohara
changed the title
elliottohara
changed the title
Contributor
Author
|
Hello @moritzzimmer ... any way I can get this reviewed. It's pretty minor and our company uses your module a lot (thanks for it btw!)... We actually have a use case that needs to trigger lambdas off rules on the non default bus. Thanks! |
Ackertron
approved these changes
Apr 4, 2023
moritzzimmer
requested changes
Apr 5, 2023
Owner
moritzzimmer
left a comment
moritzzimmer
left a comment
There was a problem hiding this comment.
Thx for the PR @elliottohara. I have just one minor remark
Owner
|
@elliottohara could you please fmt your changes/run pre-commit |
…aform-aws-lambda into fix_event_bus_name
Contributor
Author
Done. |
moritzzimmer
approved these changes
Apr 6, 2023
Contributor
Author
|
Hi @moritzzimmer ... Any way we can get this merged and released? I'd love to bump our companies modules up to this. Thanks! |
Owner
|
@elliottohara this has been released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event targets need cloudwatch event bus name if they're non default. This PR simply adds it.
Fixes #93
I've tested this locally against a lambda with triggers against a custom bus and it works as expected.