Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export #82

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Export #82

wants to merge 4 commits into from

Conversation

jpuerto-psc
Copy link

Added functionality to export tables to CSV.

@jpuerto-psc
Copy link
Author

@morlandi - pinging to get review/thoughts

@morlandi
Copy link
Owner

morlandi commented Aug 5, 2022

Hello @jpuerto-psc .. thank you for contributing.
I noticed your PR some time ago, but didn't find the time to dig into it, yet.
I totally understand the need to export from the table preserving user's choices (filters in first place) and agree on adding this functionality to the app.

My first impression is that your proposal could be improved by removing most duplicated code (both js side then Python side). I'm sure I already did it in a project, and wish to recover that code for comparison

@bradsolves
Copy link

+1 would love to see this feature implemented! Thank you both for your efforts here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants