Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move visual tests to e2e #163

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Move visual tests to e2e #163

merged 2 commits into from
Sep 13, 2021

Conversation

mormahr
Copy link
Owner

@mormahr mormahr commented Sep 13, 2021

Since most of the test assets are excluded from the build now, the image size is slightly reduced.

@mormahr mormahr force-pushed the e2e-visual-tests branch 2 times, most recently from 322e7e0 to 182e8d3 Compare September 13, 2021 13:34
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #163 (adb924e) into main (d757a5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          103       103           
=========================================
  Hits           103       103           
Flag Coverage Δ
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
/usr/src/app/pdf_service/URLFetchHandler.py
/usr/src/app/pdf_service/sentry_tags.py
/usr/src/app/pdf_service/__init__.py
/usr/src/app/pdf_service/generate.py
/usr/src/app/pdf_service/errors.py
pdf_service/errors.py 100.00% <0.00%> (ø)
pdf_service/generate.py 100.00% <0.00%> (ø)
pdf_service/__init__.py 100.00% <0.00%> (ø)
pdf_service/URLFetchHandler.py 100.00% <0.00%> (ø)
pdf_service/sentry_tags.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d757a5f...adb924e. Read the comment docs.

@mormahr mormahr force-pushed the e2e-visual-tests branch 9 times, most recently from 5fa9e1c to 4320ff0 Compare September 13, 2021 14:09
@mormahr mormahr merged commit 1e4939b into main Sep 13, 2021
@mormahr mormahr deleted the e2e-visual-tests branch September 13, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant