Skip to content

Commit

Permalink
[fix](nereids)disable NullSafeEqualToEqual rule (apache#36365)
Browse files Browse the repository at this point in the history
## Proposed changes

NullSafeEqualToEqual depends on join conjunct's nullable info. But the
nullable value may change after this rule. So convert from <=> to = may
be wrong. We disable this rule for now and fix it later
  • Loading branch information
starocean999 authored and dataroaring committed Jun 21, 2024
1 parent 83daec1 commit 0d6b80b
Showing 1 changed file with 0 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.apache.doris.nereids.rules.expression.rules.DistinctPredicatesRule;
import org.apache.doris.nereids.rules.expression.rules.ExtractCommonFactorRule;
import org.apache.doris.nereids.rules.expression.rules.LikeToEqualRewrite;
import org.apache.doris.nereids.rules.expression.rules.NullSafeEqualToEqual;
import org.apache.doris.nereids.rules.expression.rules.OrToIn;
import org.apache.doris.nereids.rules.expression.rules.SimplifyComparisonPredicate;
import org.apache.doris.nereids.rules.expression.rules.SimplifyDecimalV3Comparison;
Expand Down Expand Up @@ -52,7 +51,6 @@ public class ExpressionOptimization extends ExpressionRewrite {
ArrayContainToArrayOverlap.INSTANCE,
CaseWhenToIf.INSTANCE,
TopnToMax.INSTANCE,
NullSafeEqualToEqual.INSTANCE,
LikeToEqualRewrite.INSTANCE
)
);
Expand Down

0 comments on commit 0d6b80b

Please sign in to comment.