Skip to content

Commit

Permalink
update github template (tikv#40)
Browse files Browse the repository at this point in the history
  • Loading branch information
solotzg authored Nov 26, 2021
1 parent 9f558a1 commit e5a935f
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 130 deletions.
22 changes: 0 additions & 22 deletions .github/ISSUE_TEMPLATE/bug-report.md

This file was deleted.

37 changes: 0 additions & 37 deletions .github/ISSUE_TEMPLATE/challenge-program.md

This file was deleted.

7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATE/development-task.md

This file was deleted.

19 changes: 0 additions & 19 deletions .github/ISSUE_TEMPLATE/feature-request.md

This file was deleted.

21 changes: 0 additions & 21 deletions .github/ISSUE_TEMPLATE/question.md

This file was deleted.

44 changes: 21 additions & 23 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,40 +1,38 @@
### What problem does this PR solve?

Issue Number: close #xxx <!-- REMOVE this line if no issue to close -->
Issue Number: close #xxx

Problem Summary:

### What is changed and how it works?

Proposal: [xxx](url) <!-- REMOVE this line if not applicable -->
### Check List

What's Changed:
Tests <!-- At least one of them must be included. -->

### Related changes
- [ ] Unit test
- [ ] Integration test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No code

- PR to update `pingcap/docs`/`pingcap/docs-cn`:
- PR to update `pingcap/tidb-ansible`:
- Need to cherry-pick to the release branch
Side effects

### Check List <!--REMOVE the items that are not applicable-->
- [ ] Performance regression: Consumes more CPU
- [ ] Performance regression: Consumes more Memory
- [ ] Breaking backward compatibility

Tests <!-- At least one of them must be included. -->
Documentation

- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code

Side effects
- [ ] Affects user behaviors
- [ ] Contains syntax changes
- [ ] Contains variable changes
- [ ] Contains experimental features
- [ ] Changes MySQL compatibility

- Performance regression
- Consumes more CPU
- Consumes more MEM
- Breaking backward compatibility
### Release note

### Release note <!-- bugfixes or new feature need a release note -->
<!-- bugfix or new feature needs a release note -->

```release-note
Please add a release note.
If you don't think this PR needs a release note then fill it with None.
```
None
```
2 changes: 1 addition & 1 deletion .github/workflows/pr-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
run: |
cd ${{github.workspace}}
make gen_proxy_ffi
[[ -z $(git status -s) ]]
GIT_STATUS=$(git status -s) && if [[ ${GIT_STATUS} ]]; then echo "Error: found illegal git status"; echo ${GIT_STATUS}; [[ -z ${GIT_STATUS} ]]; fi
cargo fmt -- --check >/dev/null
- name: test
run: |
Expand Down

0 comments on commit e5a935f

Please sign in to comment.