-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3074 #2765 Applying CS and adding lacking types wherever holes have been forgotten #1
#3074 #2765 Applying CS and adding lacking types wherever holes have been forgotten #1
Conversation
5746e9f
to
8d1ebf7
Compare
@Ocramius sorry, didn't notice your PR and fixed CS violations by rebasing. Do you want to rebase on top and keep your type changes? The code style build is green now. |
@morozov can do once at the office |
Feel free to push into my branch. I'm tired restarting errored MySQL builds on Travis :-\ |
…rever holes have been forgotten
e9daa7b
to
b05053c
Compare
@@ -183,7 +183,7 @@ public function trackLastInsertId() : void | |||
* | |||
* @return string The last insert ID or '0' in case the last insert ID generated on this connection is unknown. | |||
* | |||
* @throws PDOException | |||
* @throws \PDOException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception type changed to base exception here, since the wrapped connection is accessed directly.
@morozov rebased 👍 |
@@ -13,7 +13,7 @@ class LastInsertIdTest extends DbalFunctionalTestCase | |||
/** @var Connection */ | |||
private $testConnection; | |||
|
|||
protected function setUp() | |||
protected function setUp() : void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we enforce this in the code style? Or maybe recommend to PHPUnit? Seems working even on PHP 7.2: https://3v4l.org/4QqdS
@@ -47,27 +47,27 @@ private function createTable($tableName) | |||
$connection->getSchemaManager()->createTable($table); | |||
} | |||
|
|||
public function testLastInsertIdNoInsert() | |||
public function testLastInsertIdNoInsert() : void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also could be enforced in the code style.
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
The new version contains some improvements in handling mocks (sebastianbergmann/phpunit#3602) and will help identify some existing issues in DBAL 3.0 tests: There were 2 warnings: 1) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #0 (array('test', null, 'value')) Method bindValue may not return value of type boolean 2) Doctrine\Tests\DBAL\Driver\OCI8\OCI8StatementTest::testExecute with data set #1 (array(null, 'test', 'value')) Method bindValue may not return value of type boolean
Applies to doctrine#2765 and doctrine#3074