Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong message displayed when auto-syncing in progress #2724

Closed
eben0 opened this issue Oct 16, 2024 · 3 comments
Closed

Wrong message displayed when auto-syncing in progress #2724

eben0 opened this issue Oct 16, 2024 · 3 comments

Comments

@eben0
Copy link

eben0 commented Oct 16, 2024

When Automatic Subtitles Synchronization is enabled and the current subtitle score is below the threshold, the "Downloading Subtitles" message is still displayed and has not been changed to "Syncing Subtitles".
This is misleading because the user thinks the subtitle is still downloading.

Steps to reproduce the behavior:

  1. Go to 'Settings' -> 'Subtitles' -> Automatic Subtitles Synchronization'.
  2. Enable and set Threshold.
  3. Download subtitles with a score below the configured threshold.

Expected behavior
Once downloading is complete and syncing starts the "Downloading Subtitles" message is changed to "Syncing Subtitles".

  • Bazarr: v1.4.5
  • OS: Docker
@morpheus65535
Copy link
Owner

@anderson-oki I tried implementing show_progress / hide_progress in process_subtitles() (in file subtitles/processing.py) but they never show in frontend. Any idea why?

@anderson-oki
Copy link
Collaborator

Leaving documented here.

@morpheus65535 and I discussed this over Discord, we identified the issue why the message was not being displayed, but we still have an issue where we can't track the sync progress since it just disappears.

@morpheus65535
Copy link
Owner

Should be fixed in upcoming beta. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants