-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Anidb integration soft rate limits #2556
Added Anidb integration soft rate limits #2556
Conversation
2043522
to
000a690
Compare
There's no headers that provide daily remaining calls? Any rate-limiting information? If not, I don't see anything wrong here. It would be nice to throttle just in time but if we can't and must have a soft limit. |
There is no header related to rate limits, also it seems they have some weird logic on their side, sometimes it is 300, sometimes 200, sometimes 250 per day, and once you get banned it takes between 24h and 48 hours to cooldown your IP address. However it seems if we don't reach the rate limit it cooldown in 24hours so it is much more preferable to prevent reaching the limit instead of relying on the "Banned" status they return. Also banned is not only rate limiting, so that's why it is also handled. |
Then I see no issue merging this. Lets go! |
Description
Abusing the API daily and relying on their banned status could flag the client as abusive, and instead we should prevent reaching the limit from the client side. Added a soft limit for 200 requests per day.