Updated tanstack table to v8.x #2564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request contains the minimum change to support the migration to Tanstack Table v8. There are much more space for improvements and performance optimizations but i will refactor in future commits.
Tanstack table rebuilt from the ground up, so mostly of the table had to be re-developed from the scratch while keeping all the existing feature we already had in Bazarr.
While performance can still be improved, heavy memoization, and callback also references have been used to minimize the maximum amount of re-renders as possible.
An additional, the hooks that was heavily being recreated every re-render have been moved to outside of the columns, and added as dependency instead.
Some Cell components got optimized and extracted into its own non-exported component in the same file so it can be memoized.