Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed duplicated search result name for series and movies #2682

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

anderson-oki
Copy link
Collaborator

@anderson-oki anderson-oki commented Sep 24, 2024

Description

Closes #2674

Since we perform a global search that unions Series and Movies from sonarr and radarr, there is a chance of having the same Movie and TV Show that belongs to the same year causing a conflict in the auto complete, and also the users won't know which one is the one they are looking for.

As a "fix" to prevent duplicated records, we appended (S) or (M) to represent if the result are from Movies or Series. This way you can visual identify what if the result is either a TV Show or Movie.

image

In favor to immutability the let is being dropped and refactoring in the frontend codebase.

@anderson-oki anderson-oki self-assigned this Sep 24, 2024
@anderson-oki anderson-oki marked this pull request as ready for review September 24, 2024 05:11
@anderson-oki
Copy link
Collaborator Author

Any strong opinions on this @morpheus65535?

@anderson-oki anderson-oki marked this pull request as draft September 24, 2024 23:57
@anderson-oki anderson-oki changed the title fix: Duplicated search result for series and movies Fixed duplicated search result for series and movies Sep 25, 2024
@anderson-oki anderson-oki changed the title Fixed duplicated search result for series and movies Fixed duplicated search result name for series and movies Sep 25, 2024
@anderson-oki anderson-oki marked this pull request as ready for review September 25, 2024 01:37
Copy link
Collaborator

@JaiZed JaiZed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but what do I know... :-)

@anderson-oki anderson-oki merged commit dd92f40 into development Sep 25, 2024
2 checks passed
@anderson-oki anderson-oki deleted the fix/search-duplicated-items branch September 25, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants